GSLUX-608: Use webpack uglify plugin #3079
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Working good, thx! But shouldn't we keep the |
|
You're right, I've removed the commit to get rid of the So we should wait to merge this PR until we use a v4 lib version without ol. |
AlitaBernachot
approved these changes
Oct 9, 2023
|
Closing this, having been superseeded by #3143 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR removes
HardSourceWebpackPluginand reactivatesUglifyJsPluginto minify prod js.HardSourceWebpackPluginmakes build run out of memory when usingUglifyJsPluginfor prod and seems to cause further problems in dev mode.Edit: It seems to be the bundling of the two ol instances that actually cause the out of memory error with
UglifyJsPluginand not theHardSourceWebpackPlugin. So this PR depends on a lib version without ol. However, using such a version in v3 currently still causes conflicts between mapbox/maplibre. They must be resolved here or within the 3D PR first.